feat: adds cluster-attributes to start cli command #7494
Merged
+101
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Porter <david.porter@uber.com>
davidporter-id-au
changed the title
davidporter-id-au
requested review from
3vilhamster,
Shaddoll,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
c-warren
approved these changes
Dec 1, 2025
| }, | ||
| &cli.StringFlag{ | ||
| Name: FlagClusterAttributeScope, | ||
| Usage: "Optional cluster attribute to specify how to select the active cluster. Examples might be 'region' or 'location'", |
Contributor
There was a problem hiding this comment.
NIT: As the command will fail if one of these two isn't specified I'd recommend adding something like
... Required if ClusterAttributeName is specified.
| }, | ||
| &cli.StringFlag{ | ||
| Name: FlagClusterAttributeName, | ||
| Usage: "Optional cluster attribute to be set for the workflow, used to determine, in active-active domains. This specifies which attribute to tie the workflow to, for example, if the scope is 'region' and the name is 'Lisbon' or 'San Francisco'", |
Contributor
There was a problem hiding this comment.
NIT: As the command will fail if one of these two isn't specified I'd recommend adding something like ... Required if ClusterAttributeScope is specified.
NIT: I think rephrasing to remove some commas is possible, e.g:
Optional cluster attribute name, paired with a cluster attribute scope, to specify how to select the active cluster. This specifies which attribute to tie the workflow to, for example, if the scope is 'region' and the name is 'Lisbon' or 'San Francisco'
(This doesn't actually reduce the number of commas but I think is more clear 😅 ).
davidporter-id-au
merged commit ae38f0d
into
cadence-workflow:master
62 of 64 checks passed
davidporter-id-au
deleted the
feature/adding-cluster-attr-to-cli-start-command
branch
davidporter-id-au
added a commit
that referenced
this pull request
Dec 2, 2025
<!-- Describe what has changed in this PR --> **What changed?** A follow on to #7494 since the earlier pr autoclosed <!-- Tell your future self why have you made these changes --> **Why?** <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes** Signed-off-by: David Porter <david.porter@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adds the ability to specify cluster attribute and cluster scope in the workflow start command. The goal is for customers who want to start workflows in multiple regions using the active-active feature, to be able to do so with manual cli invocations.
Why?
How did you test it?
tested locally for the start call, seems to work as expected.
Potential risks
Release notes
Documentation Changes